-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redux-React Basic Tutorial issues #1684
Labels
Comments
The tutorial really needs to be rewritten anyway, to show use of hooks instead of class components and Right now the best tutorial is actually in the Redux core docs "Fundamentals" tutorial: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Not quiet sure where else to put this.
For the Basic Tutorial https://react-redux.js.org/introduction/basic-tutorial there are 3 issues.
Issue 1: The Sandbox Code: https://codesandbox.io/s/6vwyqrpqk3 uses react: 16.4.2, but needs at least 16.8.4 because of .memo()
Issue 2: The tutorial implements the connection for the VisibilityFilters, but it omits setting the filters
const VisibilityFilters = ({ activeFilter, setFilter }) => {
Issue 3: Similar to issue 2, the tutorial doesnt implement the toggleTodo() in Todo.js.
Thanks!
The text was updated successfully, but these errors were encountered: