Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @types/hast to 3 #48

Closed
4 tasks done
crutchcorn opened this issue Aug 14, 2023 · 3 comments
Closed
4 tasks done

Upgrade @types/hast to 3 #48

crutchcorn opened this issue Aug 14, 2023 · 3 comments
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done

Comments

@crutchcorn
Copy link

Initial checklist

Problem

When using these with other newer packages that use Hast 3, we get errors due to typing mismatches.

Solution

Upgrade @types/hast to 3. However, I'm not sure if this also requires us to migrate runtime packages as well.

Alternatives

Not alternative, but a volunteer message from me that I'd be happy to work on upgrading deps wherever makes sense in this library. We depends on hast-util-to-string so anything we can do to help; let us know.

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Aug 14, 2023
@wooorm
Copy link
Member

wooorm commented Aug 14, 2023

Hey! Everything’s being released. But it takes time to go through 700+ packages.
This is also a types-only change, so you can ts-ignore/ts-expect-error and continue.
You can follow me or occasionally check https://github.com/wooorm to see where it’s currently at.

@wooorm
Copy link
Member

wooorm commented Aug 30, 2023

@wooorm wooorm closed this as completed Aug 30, 2023
@wooorm wooorm added ☂️ area/types This affects typings 💪 phase/solved Post is done labels Aug 30, 2023
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Aug 30, 2023
@crutchcorn
Copy link
Author

You're a legend @wooorm, thanks a million for all of your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done
Development

No branches or pull requests

2 participants