Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for TCP Load Balancer #630

Closed
corentone opened this issue Aug 3, 2015 · 3 comments
Closed

Support for TCP Load Balancer #630

corentone opened this issue Aug 3, 2015 · 3 comments
Milestone

Comments

@corentone
Copy link

If we can move forward with issue #491 , I would have another suggestion, adding TCP ELB support.
Heroku has the limitation of HTTP(S) but Empire doesn't have to!

One way to do it would be to arbitrarily use a TCP balancer if the port is not a known HTTP(S) port (80, 8080, 591, 8008, 443, ..).

My current workaround is to manually go edit the ELB but that seems hacky :)

@corentone corentone changed the title TCP Load Balancer Support for TCP Load Balancer Aug 3, 2015
@phobologic
Copy link
Contributor

Hey @corentone - yeah, that kind of thing is totally part of the ideas we have for the extended procfile support.

One warning about modifying things manually - it can lead to issues with a lot of stuff. You may not be able to add new config variables, or do a release, afterwards because there's a mismatch in what Empire thinks the ELB should look like vs what it really looks like.

See #627 for an example of what can go wrong.

@diranged
Copy link

This is actually a blocker for us -- we use a ton of ELBs in tcp mode so that we can use raw ask for authentication of backend systems.

Strong 👍 here!

@ejholmes ejholmes added this to the 1.0.0 milestone Aug 26, 2016
@ejholmes ejholmes modified the milestones: 0.12.0, 1.0.0 Oct 8, 2016
@ejholmes
Copy link
Contributor

ejholmes commented Oct 8, 2016

This was merged into master, and will be supported in the 0.12.0 release of Empire! Doc updates are currently in a PR at #1006

@ejholmes ejholmes closed this as completed Oct 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants