-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification when deploy finishes #888
Comments
I think this would be great if we could do it. Just to use this to record some ideas: It would be nice if we had a Within the Custom::ECSService we could return the id of the ECS deployment that the update creates, and set this as an output on the stack. Once the stack update completes, wait for all of the deployments to stabilize (move to ACTIVE state, or INACTIVE). That would be relatively straightforward to do. |
It would also be nice if the |
I worked on a proposal for how I think we should do this, and put it in the wiki. I think fundamentally what we should do, is make the |
Part one of this will be done with: #917 |
@ejholmes the last part of this i wanted to implement was always sending a notification when the release has stabilized, regardless of whether or not you specified streaming the status updates. Right now, It feels weird that the empire event behaves differently depending on a small detail like whether or not the user wanted to stream updates on the cli. I like how all events are published within https://github.com/remind101/empire/blob/master/empire.go, to maintain consistency with that, I think we should do something like:
that way the events are always being published at the same time, regardless of whether streaming was specified and we also don't introduce publishing events in other parts of the stack. the We can also setup a timeout within the Thoughts? |
With the recent changes that @mhahn did, I think we can go ahead and close this. When the |
After a deploy, I usually poll
emp ps
to know when the last release has been completely phased out.Wouldn't it be nice to receive a notification instead.
The text was updated successfully, but these errors were encountered: