Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many compilation warnings in OCaml emulator: ignored-partial-application #507

Open
Kakadu opened this issue Jul 3, 2024 · 1 comment
Open

Comments

@Kakadu
Copy link

Kakadu commented Jul 3, 2024

The CI version builds OCaml emulator with a lot of warnings. The most severe of them is

File "riscv.ml", line 12439, characters 4-48:
12439 |     Softfloat.f64_round_to_int (zrm, zv, zexact);
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning 5 [ignored-partial-application]: this function application is partial,
maybe some arguments are missing.

The compiler says that this function is not really called, and extra argument(s) seems to be forgotten. This means that correctness of the emulator could be in danger.

P.S. I couldn't find mentions about this neither here nor in https://github.com/rems-project/sail/issues . Maybe I should cross-post...

@Timmmm
Copy link
Collaborator

Timmmm commented Jul 4, 2024

Yeah I noticed this too. The OCaml emulator doesn't actually support float currently anyway so it's probably not a big deal. This will change when the float implementation is moved from Berkeley softfloat to native Sail, which which case these functions will be deleted anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants