-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for signed URLs in GCP #22
Comments
Can you suggest which APIs need to change/new APIs needed so I can understand the interface you are looking at? |
AWS's blob interface has definitions for pre-signed URLs for upload and download. Google Cloud also supports pre-signed URLs for upload and download in a similar manner of returning a signed URL: Aside for the mime type in the AWS method declaration, the same method declaration can be used for GCP. From what I can tell, the GCP implementation does not have a base interface, but rather inherit from GenericBlobStorage. If I had to make a suggestion, I would probably add an interface to extend the capabilities of the GenericBlobStorage for Google Cloud as a first step, and eventually update the extended IBlobStorage interface to support pre-signed URLs, as they exist in most cloud storage providers. The implementation for GCP can either sign locally if a service account key is available. If a signing key is not available, the implementation can call the signBlob API to sign the URL. |
Both the AWS and Azure interfaces for blobs, IAwsS3BlobStorage and IAzureBlobStorage have a definition for pre-signed/SAS URLs (GetUploadUrlAsync for AWS and GetBlobSasAsync for AWS).
Can we please:
The text was updated successfully, but these errors were encountered: