-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Servicebus: Migrate to new SDK and imeplement missing methods #44
Comments
Need to write some more xml comments and integration test. I also added some utility method in the If it sounds good to you i can prepare a PR |
Sounds excellent to me! Please make a PR asap! We shall overwrite the old project. No need to make a new project. Less is better. Please change the old project itself as required. I will release a major version package of it to indicate breaking changes. |
Hello,
the AzureServicebus plugin for FluentStorage is implemented with the package
Microsoft.Azure.ServiceBus
wich is deprecated since 2021. I cannot use it in any of my projects cause conflicts with outated references:Version conflict detected for System.IdentityModel.Tokens.Jwt. I
Also there are missing functionalities, in the wiki we have this:
But in realty only these methods are currently implemented:
![image](https://private-user-images.githubusercontent.com/8319337/278718362-82199404-433c-4fc9-b8b6-59c718c39f5f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk3NzM0NDUsIm5iZiI6MTcxOTc3MzE0NSwicGF0aCI6Ii84MzE5MzM3LzI3ODcxODM2Mi04MjE5OTQwNC00MzNjLTRmYzktYjhiNi01OWM3MThjMzlmNWYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYzMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MzBUMTg0NTQ1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDM5MTdkMDc5NjQ4NTlmN2NhN2IzMTJiZjRjNGQ2YmM2OThiYzdkNzdhYmI2YTAxYzY1OTQ5ZmRiNzFkZDhmYSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.X5hI49uDfTKbhyOBx99Xgbnus5y2A5tROZj_L7LyYXk)
Plus i'm not 100% sure that sending directly to subiscriptions will work with the actual code.
I'm implementing a PR wich fixes everything and use the current, supported package.
Should my PR replace the current plugin (there would be breaking changes, is inevitable) or should i make a new package
FluentStorage.Azure.Messaging.ServiceBus
(wich is similar to the name of the new Microsoft package) e maintain the older for retrocompatibility?The text was updated successfully, but these errors were encountered: