Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontParts Site - Object Tree missing "Groups" #539

Open
colinmford opened this issue Aug 3, 2020 · 7 comments
Open

FontParts Site - Object Tree missing "Groups" #539

colinmford opened this issue Aug 3, 2020 · 7 comments

Comments

@colinmford
Copy link
Collaborator

Hey all,

I just realized the "object tree" found here is missing a "Groups" bubble coming off of "Font"... I guess it should go in that empty space next to "Features"?

Screen Shot 2020-08-03 at 3 12 26 PM

@arrowtype / @thundernixon I'm not sure how to edit the site to make a PR to fix this... Do I just edit this file?

https://github.com/robotools/fontParts/blob/master/documentation/source/_themes/fontPartsTheme/static/diagrams/fp-object-tree.svg

@arrowtype
Copy link
Contributor

Well spotted, Colin!

It’s been quite awhile since I touched the docs here, but yes, I think you would probably edit that SVG, and then you would probably also have to copy that updated SVG code into the raw HTML at:

https://github.com/robotools/fontParts/blob/master/documentation/source/objectref/objects/index.rst

@gferreira
Copy link
Contributor

gferreira commented Aug 3, 2020

@colinmford
Copy link
Collaborator Author

colinmford commented Aug 6, 2020

@gferreira @typemytype Is it ok to use that RF Docs SVG you linked to replace the current one on the FontParts site?

@arrowtype once I update it, how would you recommend previewing the page to make sure it's correct? Do I need to rebuild the documentation from source locally?

@gferreira
Copy link
Contributor

@colinmford yes, feel free to use it. you’ll just need to update the URLs and the font.

@simoncozens
Copy link
Contributor

FWIW, .groups and similar accessors should also be added to the documentation for the Font object.

@benkiel
Copy link
Member

benkiel commented Nov 4, 2020

@simoncozens I am 100% likely missing it, but isn't it there: https://fontparts.robotools.dev/en/stable/objectref/objects/font.html#fontParts.base.BaseFont.groups ?

Let me know what I got wrong, it's been a day.

@simoncozens
Copy link
Contributor

I have no idea how I missed that. Sorry, as you were...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants