Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NL at EOF? #11

Open
krlmlr opened this issue Dec 31, 2019 · 1 comment
Open

NL at EOF? #11

krlmlr opened this issue Dec 31, 2019 · 1 comment

Comments

@krlmlr
Copy link
Contributor

krlmlr commented Dec 31, 2019

Most .sh files are missing a final newline. I have tried to work around with editorconfig, but this isn't supported with my editor: editorconfig/editorconfig-vscode#153.

Do you feel strongly about newlines at EOF? Would an .editorconfig that enables this setting only for this project help?
@roeme
Copy link
Owner

roeme commented Jan 11, 2020

Nah, I don't feel strongly about them. My tools don't really care, and the odd diff highlighting a \r,\n or \r\n doesn't impede anything here. Feel free to PR adding newlines. As for editorconfig, I don't use it, I prefer Modelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roeme @krlmlr