v5 breaks modules which assign reserved keywords to module.exports

[leeyeh]

Upgrading to v5.0.3 from v4 breaks build:

SyntaxError: /home/travis/build/leancloud/js-realtime-sdk/node_modules/axios/lib/axios.js: Unexpected token (55:4)
  53 | 
  54 | // Allow use of default import syntax in TypeScript
> 55 | var default = axios;
     |     ^
  56 | 
  57 | export default axios_1;
  58 | export { axios_1 as __moduleExports };

The source code of axios looks like:

// Allow use of default import syntax in TypeScript
module.exports.default = axios;

[Rich-Harris]

Hey @leeyeh, I think this is the same as #112 which was just fixed – can you try the latest version and see if it's 👍 ? Thanks

[leeyeh]

still broken https://travis-ci.org/leancloud/js-realtime-sdk/builds/160891784#L1648

I believe this issue is about reserved keywords.

[lxe]

Same things with "delete" and other reserved keywords

[dhndeveloper]

Having a similar issue...

[youzi]

I'm having a similar issue with a dependency defining: exports.static = function () {}

Error parsing x: The keyword 'static' is reserved (23:4) in x

I'm using 'rollup-plugin-commonjs@5.0.5' in combination with 'rollup-plugin-node-resolve@2.0.0'

[youzi]

Ok so seems to be an Acorn issue. I was able to work around this by passing options to Acorn: rollup/rollup#564

[Rich-Harris]

This is the same issue as #116, I think – have just released 6.0.0 with a fix. Let me know if you still have problems, thanks

[mortargrind]

This is broken in version 7.0.0. When you try to import axios from 'axios';, you'll get Error: Duplicate export 'default'. When you delete module.exports.default = axios; line in the "node_modules/axios/lib/axios.js", it will compile (I don't know if the output will be correct, i have other errors :) ) Acorn option allowReserverd: true does not solve this.

[lukasjuhas]

I'm having same problem @mortargrind. Thanks for the tip, it does work if I comment out / delete that line.

[leeyeh]

I can confirm it's still broken for the keyword default: https://travis-ci.org/leancloud/js-realtime-sdk/builds/190498378#L1205

I can file a new issue if preferred. @Rich-Harris

[Rich-Harris]

I think this will have been fixed by #173 — could you try installing the latest version to see? Thanks, sorry for the delayed response

[leeyeh]

Confirmed. Thank you.