From 165eae9ba98919b31f15bbe87097f0907785a23a Mon Sep 17 00:00:00 2001 From: Victorien Elvinger Date: Mon, 26 Jun 2023 12:15:45 +0200 Subject: [PATCH] docs: fix `noCommaOperator` example --- .../src/analyzers/style/no_comma_operator.rs | 2 +- website/src/pages/lint/rules/noCommaOperator.md | 16 ++++++---------- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/crates/rome_js_analyze/src/analyzers/style/no_comma_operator.rs b/crates/rome_js_analyze/src/analyzers/style/no_comma_operator.rs index b5870f60f58..5186cb9f6fa 100644 --- a/crates/rome_js_analyze/src/analyzers/style/no_comma_operator.rs +++ b/crates/rome_js_analyze/src/analyzers/style/no_comma_operator.rs @@ -19,7 +19,7 @@ declare_rule! { /// ### Invalid /// /// ```js,expect_diagnostic - /// const foo = doSomething(), 0; + /// const foo = (doSomething(), 0); /// ``` /// /// ```js,expect_diagnostic diff --git a/website/src/pages/lint/rules/noCommaOperator.md b/website/src/pages/lint/rules/noCommaOperator.md index 44fbc28a6c4..88368bbd06b 100644 --- a/website/src/pages/lint/rules/noCommaOperator.md +++ b/website/src/pages/lint/rules/noCommaOperator.md @@ -22,22 +22,18 @@ Source: https://eslint.org/docs/latest/rules/no-sequences ### Invalid ```jsx -const foo = doSomething(), 0; +const foo = (doSomething(), 0); ``` -
style/noCommaOperator.js:1:28 parse ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
style/noCommaOperator.js:1:27 lint/style/noCommaOperator ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-   expected an identifier, an array pattern, or an object pattern but instead found '0'
+   The comma operator is disallowed.
   
-  > 1 │ const foo = doSomething(), 0;
-                              ^
+  > 1 │ const foo = (doSomething(), 0);
+                             ^
     2 │ 
   
-   Expected an identifier, an array pattern, or an object pattern here
-  
-  > 1 │ const foo = doSomething(), 0;
-                              ^
-    2 │ 
+   Its use is often confusing and obscures side effects.