diff --git a/crates/rome_analyze/src/analyzers.rs b/crates/rome_analyze/src/analyzers.rs index 537dea2909a..7f3cd3cbbe9 100644 --- a/crates/rome_analyze/src/analyzers.rs +++ b/crates/rome_analyze/src/analyzers.rs @@ -6,7 +6,7 @@ mod no_double_equals; pub(crate) use no_double_equals::NoDoubleEquals; mod use_single_var_declarator; pub(crate) use use_single_var_declarator::UseSingleVarDeclarator; +mod use_valid_typeof; +pub(crate) use use_valid_typeof::UseValidTypeof; mod use_while; pub(crate) use use_while::UseWhile; -mod valid_typeof; -pub(crate) use valid_typeof::ValidTypeof; diff --git a/crates/rome_analyze/src/analyzers/valid_typeof.rs b/crates/rome_analyze/src/analyzers/use_valid_typeof.rs similarity index 98% rename from crates/rome_analyze/src/analyzers/valid_typeof.rs rename to crates/rome_analyze/src/analyzers/use_valid_typeof.rs index daac42dabc9..6b9ffdb5e15 100644 --- a/crates/rome_analyze/src/analyzers/valid_typeof.rs +++ b/crates/rome_analyze/src/analyzers/use_valid_typeof.rs @@ -12,10 +12,10 @@ use crate::{ ActionCategory, RuleCategory, }; -pub(crate) enum ValidTypeof {} +pub(crate) enum UseValidTypeof {} -impl Rule for ValidTypeof { - const NAME: &'static str = "validTypeof"; +impl Rule for UseValidTypeof { + const NAME: &'static str = "useValidTypeof"; const CATEGORY: RuleCategory = RuleCategory::Lint; type Query = JsBinaryExpression; diff --git a/crates/rome_analyze/src/registry.rs b/crates/rome_analyze/src/registry.rs index 691bf815738..aec82883291 100644 --- a/crates/rome_analyze/src/registry.rs +++ b/crates/rome_analyze/src/registry.rs @@ -39,8 +39,8 @@ impl_registry_builders!( NoDelete, NoDoubleEquals, UseSingleVarDeclarator, + UseValidTypeof, UseWhile, - ValidTypeof, // Assists FlipBinExp, ); diff --git a/crates/rome_analyze/tests/specs/validTypeof.js b/crates/rome_analyze/tests/specs/useValidTypeof.js similarity index 100% rename from crates/rome_analyze/tests/specs/validTypeof.js rename to crates/rome_analyze/tests/specs/useValidTypeof.js diff --git a/crates/rome_analyze/tests/specs/validTypeof.js.snap b/crates/rome_analyze/tests/specs/useValidTypeof.js.snap similarity index 71% rename from crates/rome_analyze/tests/specs/validTypeof.js.snap rename to crates/rome_analyze/tests/specs/useValidTypeof.js.snap index 5a5d99b83be..da3f042a423 100644 --- a/crates/rome_analyze/tests/specs/validTypeof.js.snap +++ b/crates/rome_analyze/tests/specs/useValidTypeof.js.snap @@ -1,6 +1,6 @@ --- source: crates/rome_analyze/tests/spec_tests.rs -expression: validTypeof.js +expression: useValidTypeof.js --- # Input ```js @@ -26,8 +26,8 @@ typeof foo == -5 # Diagnostics ``` -error[validTypeof]: Invalid typeof comparison value - ┌─ validTypeof.js:7:1 +error[useValidTypeof]: Invalid typeof comparison value + ┌─ useValidTypeof.js:7:1 │ 7 │ typeof foo === "strnig" │ ^^^^^^^^^^^^^^^^^^^^^^^ Invalid typeof comparison value @@ -36,8 +36,8 @@ error[validTypeof]: Invalid typeof comparison value ``` ``` -error[validTypeof]: Invalid typeof comparison value - ┌─ validTypeof.js:8:1 +error[useValidTypeof]: Invalid typeof comparison value + ┌─ useValidTypeof.js:8:1 │ 8 │ typeof foo == "undefimed" │ ^^^^^^^^^^^^^^^^^^^^^^^^^ Invalid typeof comparison value @@ -46,8 +46,8 @@ error[validTypeof]: Invalid typeof comparison value ``` ``` -error[validTypeof]: Invalid typeof comparison value - ┌─ validTypeof.js:9:1 +error[useValidTypeof]: Invalid typeof comparison value + ┌─ useValidTypeof.js:9:1 │ 9 │ typeof bar != "nunber" │ ^^^^^^^^^^^^^^^^^^^^^^ Invalid typeof comparison value @@ -56,8 +56,8 @@ error[validTypeof]: Invalid typeof comparison value ``` ``` -error[validTypeof]: Invalid typeof comparison value - ┌─ validTypeof.js:10:1 +error[useValidTypeof]: Invalid typeof comparison value + ┌─ useValidTypeof.js:10:1 │ 10 │ typeof bar !== "fucntion" │ ^^^^^^^^^^^^^^^^^^^^^^^^^ Invalid typeof comparison value @@ -66,8 +66,8 @@ error[validTypeof]: Invalid typeof comparison value ``` ``` -error[validTypeof]: Invalid typeof comparison value - ┌─ validTypeof.js:13:1 +error[useValidTypeof]: Invalid typeof comparison value + ┌─ useValidTypeof.js:13:1 │ 13 │ typeof foo === undefined │ ^^^^^^^^^^^^^^^^^^^^^^^^ Invalid typeof comparison value @@ -87,8 +87,8 @@ Compare the result of `typeof` with a valid type name ``` ``` -error[validTypeof]: Invalid typeof comparison value - ┌─ validTypeof.js:14:1 +error[useValidTypeof]: Invalid typeof comparison value + ┌─ useValidTypeof.js:14:1 │ 14 │ typeof bar == Object │ ^^^^^^^^^^^^^^^^^^^^ Invalid typeof comparison value @@ -108,8 +108,8 @@ Compare the result of `typeof` with a valid type name ``` ``` -error[validTypeof]: Invalid typeof comparison value - ┌─ validTypeof.js:15:1 +error[useValidTypeof]: Invalid typeof comparison value + ┌─ useValidTypeof.js:15:1 │ 15 │ typeof foo === baz │ ^^^^^^^^^^^^^^^^^^ Invalid typeof comparison value @@ -118,8 +118,8 @@ error[validTypeof]: Invalid typeof comparison value ``` ``` -error[validTypeof]: Invalid typeof comparison value - ┌─ validTypeof.js:16:1 +error[useValidTypeof]: Invalid typeof comparison value + ┌─ useValidTypeof.js:16:1 │ 16 │ typeof foo == 5 │ ^^^^^^^^^^^^^^^ Invalid typeof comparison value @@ -128,8 +128,8 @@ error[validTypeof]: Invalid typeof comparison value ``` ``` -error[validTypeof]: Invalid typeof comparison value - ┌─ validTypeof.js:17:1 +error[useValidTypeof]: Invalid typeof comparison value + ┌─ useValidTypeof.js:17:1 │ 17 │ typeof foo == -5 │ ^^^^^^^^^^^^^^^^ Invalid typeof comparison value