Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

📎 Consider ignoring invisible characters when displaying diffs #3327

Closed
sebmck opened this issue Oct 4, 2022 · 0 comments · Fixed by #3334
Closed

📎 Consider ignoring invisible characters when displaying diffs #3327

sebmck opened this issue Oct 4, 2022 · 0 comments · Fixed by #3334
Assignees
@leops
Labels
A-Diagnostic Area: errors and diagnostics task A task, an action that needs to be performed

Comments

@sebmck
Copy link
Contributor

sebmck commented Oct 4, 2022

Description

I love the new diff output, especially how we display invisible characters like spaces and tabs. However it can be a bit distracting on lines without any changes. We should consider displaying them without the → and · characters for unmodified lines.

Screen Shot 2022-10-04 at 2 42 02 PM
@sebmck sebmck added the task A task, an action that needs to be performed label Oct 4, 2022
@leops leops mentioned this issue Oct 5, 2022
Merged
@ematipico ematipico added the A-Diagnostic Area: errors and diagnostics label Oct 5, 2022
@ematipico ematipico added this to the 10.0.0 milestone Oct 5, 2022
@ematipico ematipico removed this from the 10.0.0 milestone Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@leops leops

Labels
A-Diagnostic Area: errors and diagnostics task A task, an action that needs to be performed
Projects
Rome 2022
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rome_diagnostics): do not print invisible characters on unchanged diff lines rome/tools
3 participants
@ematipico @sebmck @leops