-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to make external cluster Json flags distributed #14183
Labels
ceph-external
Ceph in external cluster mode
feature
good-first-issue
Simple issues that are good for getting started with Rook.
Comments
parth-gr
added
feature
good-first-issue
Simple issues that are good for getting started with Rook.
ceph-external
Ceph in external cluster mode
labels
May 9, 2024
Hey @parth-gr, after running the python script [
{
"name": "rook-ceph-mon-endpoints",
"kind": "ConfigMap",
"data": {
"data": "a=10.96.180.5:6789",
"maxMonId": "0",
"mapping": "{}"
}
},
{
"name": "rook-ceph-mon",
"kind": "Secret",
"data": {
"admin-secret": "admin-secret",
"fsid": "f52ee175-3f3a-4828-a6af-8d4962dbd9e0",
"mon-secret": "mon-secret"
}
},
{
"name": "monitoring-endpoint",
"kind": "CephCluster",
"data": {
"MonitoringEndpoint": "10.244.0.15",
"MonitoringPort": "9283"
}
},
...
{
"name": "ceph-rbd",
"kind": "StorageClass",
"data": {
"pool": "replicapool",
"csi.storage.k8s.io/provisioner-secret-name": "rook-csi-rbd-provisioner",
"csi.storage.k8s.io/controller-expand-secret-name": "rook-csi-rbd-provisioner",
"csi.storage.k8s.io/node-stage-secret-name": "rook-csi-rbd-node"
}
},
...
] so, segregate secured and non-secured flags in the JSON would be something like - {
"secured": [
{
"name": "rook-ceph-mon",
"kind": "Secret",
"data": {
"admin-secret": "admin-secret",
"fsid": "f52ee175-3f3a-4828-a6af-8d4962dbd9e0",
"mon-secret": "mon-secret"
}
},
...
],
"non-secured": [
{
"name": "rook-ceph-mon-endpoints",
"kind": "ConfigMap",
"data": {
"data": "a=10.96.180.5:6789",
"maxMonId": "0",
"mapping": "{}"
}
},
{
"name": "monitoring-endpoint",
"kind": "CephCluster",
"data": {
"MonitoringEndpoint": "10.244.0.15",
"MonitoringPort": "9283"
}
},
...
]
} and dump non-secured part to the logs? |
IMO, Instead of deciding what all can be logged and is not-secured, I think we can start from logging what all things are needed rn for debug and are non-secured. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ceph-external
Ceph in external cluster mode
feature
good-first-issue
Simple issues that are good for getting started with Rook.
Is this a bug report or feature request?
Currently all the secured and non-secured information is dumped at one place,
So if any nonsecured information is needed for debugging like endpoints details, which cant be made available through logs,
So segregate the secured and the non secured items in the JSON blob
Environment:
The text was updated successfully, but these errors were encountered: