Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexposed fields? #7

Closed
mustberuss opened this issue Dec 23, 2017 · 2 comments
Closed

Unexposed fields? #7

mustberuss opened this issue Dec 23, 2017 · 2 comments

Comments

@mustberuss
Copy link
Collaborator

addme.txt
Hi, I'm a first time issue creator who's hoping I'm doing this correctly.

Someone posted in the patentsview api forum that the examiner_id is not present. It's a moderated list so my reply doesn't show up yet but I think the problem is here. The api does return the field in a browser request or in R doing a get on the endpoint. It's always coming back as null which is an api issue but shouldn't it be accessible in this package? I got the same error the poster got with the stable and dev packages.

I wrote a perl script to scrape and compare the api's endpoint pages to fieldsdf.csv It shows that the examiner fields are missing in fieldsdf.csv for all 7 endpoints. I've attached the fields my script thinks are missing. I could fork or pull something if this is an issue

github and R novice

@crew102
Copy link
Collaborator

crew102 commented Dec 23, 2017

Greetings @mustberuss, thanks for the heads up. Yes, regarding the fact that it shouldn't be coming back as null in your browser (perhaps open up an issue here for that: https://github.com/CSSIP-AIR/PatentsView-API), and yes, the patentsview r package should nevertheless be passing those nulls along. You can re-run the script that pulls the latest fields from the API's website (as I just have) and open a PR request for the package to update the fields. The dev version of patentsview should work for you now.

@mustberuss
Copy link
Collaborator Author

@crew102, that is too cool! You are correct, my dev version is working now. PR opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants