Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] ubuntu-latest will be 20.04, macOS-11.0 Big Sur #94

Closed
MSP-Greg opened this issue Oct 18, 2020 · 5 comments
Closed

[misc] ubuntu-latest will be 20.04, macOS-11.0 Big Sur #94

MSP-Greg opened this issue Oct 18, 2020 · 5 comments

Comments

@MSP-Greg
Copy link
Collaborator

You've probably seen them, but just in case:

actions/runner-images#1816 - Ubuntu-latest workflows will use Ubuntu-20.04

Other than the changed OpenSSL 'security_level', not much of a change between 19.04 and 20.04. I have suggested that workflows use the numeric style rather than 'latest'...

actions/runner-images#1814 - macOS 11.0 (Big Sur) is available as a preview

Not knowledgeable re macOS. I have used a 10.15 Ruby build with 11.0. They don't mention whether they will be removing 10.15 or not. Then again, they mentioned that windows-2016 would be removed a long time ago...

@eregon
Copy link
Member

eregon commented Oct 18, 2020

I didn't, thanks for the notice.
ubuntu-latest changing to 20.04 shouldn't affect anything for this action.

OTOH when macos-latest changes to Big Sur, we'll need to be more careful if builds on Catalina don't run there. Probably they will. I guess we should test on macOS Big Sur to make sure the action work, and find out whether we can reuse builds from Catalina or not. Probably versioning all OS for builds is safer for the future, although building for more platforms is some overhead (especially for nightly builds).

@MSP-Greg
Copy link
Collaborator Author

MSP-Greg commented Oct 18, 2020

we should test on macOS Big Sur to make sure the action work

I've run Ruby 2.7 and JRuby on Big Sur in my Puma fork, both passed CI, so Puma compiled and tested ok.

Probably versioning all OS for builds is safer for the future

True, but a PITA

Ok to close whenever

@MSP-Greg
Copy link
Collaborator Author

@eregon

Big Sur just broke, seeing an error logged from here of 'Unknown ImageOS macos11'.

Not sure of the cause, the code below has a regex that matches against ENV['ImageOS'].
'macos-10.15' has an env value of macos1015, but currently 'macos-11.0' is macos11. Hence, the regex below fails, and throws the above error...

setup-ruby/common.js

Lines 55 to 58 in ad1ebae

match = imageOS.match(/^macos(\d{2})(\d+)/) // e.g. macos1015
if (match) {
return `macos-${match[1]}.${match[2]}`
}

@eregon
Copy link
Member

eregon commented Nov 13, 2020

I see, will fix. I was thinking we should test on macos-11.0, well, this is a good reason for it.
Unfortunate that it's not macos110/macos1100 or so.

@eregon
Copy link
Member

eregon commented Nov 13, 2020

Fixed and tested in https://github.com/ruby/setup-ruby/releases.

TruffleRuby needs new builds for macos-11.0 though:
#109

@eregon eregon closed this as completed Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants