Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Chrome version #55

Open
volt4ire opened this issue Jul 14, 2021 · 4 comments
Open

Provide Chrome version #55

volt4ire opened this issue Jul 14, 2021 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@volt4ire
Copy link

I frequently switch between Chrome and Firefox, so would love to have this extension's functionality in Chrome. I know they both use WebExtensions but I'm not sure how easy porting from one implementation to the other would be.

@volt4ire volt4ire added the enhancement New feature or request label Jul 14, 2021
@rugk
Copy link
Owner

rugk commented Jul 15, 2021

Sure, it's a good idea. As always, I refer to rugk/offline-qr-code#59 for details on how to make it.

The TL;DR is: The code base must keep supporting the new WebExtension (promise-based) API of Firefox, but we can include polyfills in the Chrome/ium version. Whether all features really work is not clear, though.

For example, I remember this add-on uses the webRequest to intercept them, though they are not blocked, so the API removal of Chrome/ium regarding adblockers, may not affect this add-on.

@rugk rugk added this to the v1.4 milestone Apr 27, 2022
@rugk rugk removed this from the v1.4 milestone Jun 12, 2022
@rugk rugk added the help wanted Extra attention is needed label Jun 12, 2022
@kerim
Copy link

kerim commented Nov 10, 2022

+1 for a Chrome version

@samuk
Copy link

samuk commented Nov 18, 2022

+1

@rugk
Copy link
Owner

rugk commented Nov 19, 2022

Please use the 👍 emoji/reaction for upvoting an issue instead of commenting and thus bumping it, so people can follow on relevant updates here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants