Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impact of adding a [[test]] section isn't documented. #4290

Closed
epage opened this issue Jul 17, 2017 · 2 comments
Closed

Impact of adding a [[test]] section isn't documented. #4290

epage opened this issue Jul 17, 2017 · 2 comments
Labels
A-documenting-cargo-itself Area: Cargo's documentation

Comments

@epage
Copy link
Contributor

epage commented Jul 17, 2017 •
edited
Loading

In liquid-rust, I added a [[test]] to specify the needed features to run the tests. It turns out I didn't set this up correctly, but more of issue is the fact that it disabled all of the implicit [[test]] targets without the documentation giving any hint that this will happen.
@epage epage mentioned this issue Jul 17, 2017
Closed
@alexcrichton alexcrichton added the A-documenting-cargo-itself Area: Cargo's documentation label Jul 17, 2017
@dwijnand
Copy link
Member

While still not documented, the impact at least triggers a runtime lint-like warning with #5330 shipped.

@ehuss
Copy link
Contributor

ehuss commented Jun 24, 2019

Adding a target definition no longer disables implicit targets with the 2018 edition.

More documentation has been added for this #6898 (https://doc.rust-lang.org/nightly/cargo/reference/manifest.html#target-auto-discovery), so closing as fixed.

@ehuss ehuss closed this as completed Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-documenting-cargo-itself Area: Cargo's documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ehuss @epage @alexcrichton @dwijnand