From e48086c04fb8092253ab638c6b0aa82b09edc8d0 Mon Sep 17 00:00:00 2001 From: Oliver Middleton Date: Fri, 19 May 2017 02:59:04 +0100 Subject: [PATCH] rustdoc: Fix implementors list javascript * Use a different loop variable, `i` was already taken. This caused missing items in the implementors list. * Use `.getAttribute('href')` rather than `.href` to get the relative URL which is what it needs to actually fix the links. --- src/librustdoc/html/static/main.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/librustdoc/html/static/main.js b/src/librustdoc/html/static/main.js index c115a6ccba609..e85f70ffedcc8 100644 --- a/src/librustdoc/html/static/main.js +++ b/src/librustdoc/html/static/main.js @@ -1083,10 +1083,10 @@ code.innerHTML = structs[j]; var x = code.getElementsByTagName('a'); - for (var i = 0; i < x.length; i++) { - var href = x[i].href; + for (var k = 0; k < x.length; k++) { + var href = x[k].getAttribute('href'); if (href && href.indexOf('http') !== 0) { - x[i].href = rootPath + href; + x[k].setAttribute('href', rootPath + href); } } var li = document.createElement('li');