Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove TypeRelation::{intercrate,mark_ambiguous} #109863

Closed
aliemjay opened this issue Apr 2, 2023 · 0 comments · Fixed by #109917
Closed

remove TypeRelation::{intercrate,mark_ambiguous} #109863

aliemjay opened this issue Apr 2, 2023 · 0 comments · Fixed by #109917
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@aliemjay
Copy link
Member

aliemjay commented Apr 2, 2023

Introduced in #103488, they are used only in super_relate_tys.

I believe super_relate_tys should always relate types structurally. Any smarter inference rules should be handled by the caller instead, similar to how we do lazy normalization in the new solver.

@aliemjay aliemjay added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 2, 2023
@bors bors closed this as completed in be8e5ba Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant