Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve display of type kind in search results #112721

Closed
GuillaumeGomez opened this issue Jun 16, 2023 · 6 comments
Closed

Improve display of type kind in search results #112721

GuillaumeGomez opened this issue Jun 16, 2023 · 6 comments
Labels
A-rustdoc-ui Area: rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

In #110688, the type kind was added before the type name. However, having a visual distinction would make the reading better. Something making the text bold could work maybe? To be discussed.

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: rustdoc UI (generated HTML) labels Jun 16, 2023
@junderw
Copy link

junderw commented Jun 17, 2023

Suggestion:

  • Make the type kind the same color as the item itself
  • Make the type kind bold

I wasn't aware that the colors in the search results corresponded to a type kind, so making the type kind the same color would help cement that in the viewers mind.

@dns2utf8
Copy link
Contributor

I would prefer the kind of item be a specific icon with the alt text shown on hover

@GuillaumeGomez
Copy link
Member Author

Just for your information, @poliorcetics opened #112720. I think it's a nice improvement of the current situation.

I would prefer the kind of item be a specific icon with the alt text shown on hover

I'm not sure it's a good idea to ask users to remember more symbols to make UI shorter.

@dns2utf8
Copy link
Contributor

That is a good point

@poliorcetics
Copy link
Contributor

Make the type kind the same color as the item itself

I experimented with that in my PR and it's way too distracting imo.

I ended up on using the same grey for all item kinds to make it less eye catching

@GuillaumeGomez
Copy link
Member Author

Fixed by #112720.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants