Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color differences between found and expected in errors #21334

Closed
mdinger opened this issue Jan 17, 2015 · 6 comments
Closed

Color differences between found and expected in errors #21334

mdinger opened this issue Jan 17, 2015 · 6 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@mdinger
Copy link
Contributor

mdinger commented Jan 17, 2015

Apply coloring to highlight the differences between found and expected errors and which is desired. This pic is old and slightly out of date but shows what I'm interested in:
color_error

@mdinger mdinger changed the title Color differences between *found* and *expected* in errors Color differences between found and expected in errors Jan 17, 2015
@kmcallister kmcallister added A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Jan 18, 2015
@ahmedcharles
Copy link
Contributor

I looked into this. It would seem that there isn't an easy way to do this and it would probably require extending the diagnostics framework to make this work without making it seem hacky.

@steveklabnik
Copy link
Member

Triage: no change.

@steveklabnik steveklabnik added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 9, 2017
@estebank
Copy link
Contributor

estebank commented Jun 2, 2017

#41205 addresses this with bolding, not coloring. It does so at the type level, not at the path segment level.

@mdinger
Copy link
Contributor Author

mdinger commented Jun 4, 2017

That looks better than what is currently available. You might want to mark this as a possible future extension. Not having used the other, this might not even be necessary depending on how well the other works out in practice.

@estebank
Copy link
Contributor

estebank commented Aug 14, 2018

@mdinger it's been a while since the highlighting code has been in the wild. Do you still miss this the coloring feature despite this?

@mdinger
Copy link
Contributor Author

mdinger commented Aug 15, 2018

I don't have a strong opinion. I'd mark it as WFM. If someone else wants it, they can reopen.

@mdinger mdinger closed this as completed Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants