Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slice impl for [T; i] is repeated too much in rustdoc #21660

Closed
mdinger opened this issue Jan 26, 2015 · 8 comments
Closed

slice impl for [T; i] is repeated too much in rustdoc #21660

mdinger opened this issue Jan 26, 2015 · 8 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@mdinger
Copy link
Contributor

mdinger commented Jan 26, 2015

The slice page is huge. These [T; N] really need to be condensed at least in rustdoc somehow. This is absurd.

impl<T> Clone for [T; 0] where T: Copy
...
impl<S, T> Hash<S> for [T; 0] where S: Hasher, S: Writer, T: Hash<S>
...
Repeats for 0...31 along with all the sub-functionality each `impl` brings
...
impl<T> Clone for [T; 32] where T: Copy
...
impl<S, T> Hash<S> for [T; 32] where S: Hasher, S: Writer, T: Hash<S>
@lifthrasiir
Copy link
Contributor

#[doc(hidden)] for every impl but one and put a note on that one?

@mdinger
Copy link
Contributor Author

mdinger commented Jan 27, 2015

Sounds good to me. 70% of that page is that type.

@huonw huonw added the A-docs label Jan 27, 2015
@huonw
Copy link
Member

huonw commented Jan 27, 2015

It seems like rustdoc could just treat all [T; ...] as the same, by default (providing e.g. mouse-over text or a [+] button to give the exact lengths that are implemented).

@steveklabnik
Copy link
Member

pssssh, we're fine

@tomjakubowski
Copy link
Contributor

@steveklabnik it's... beautiful

@tomjakubowski
Copy link
Contributor

I think @lifthrasiir's suggestion is a good workaround for the standard docs but rustdoc could certainly stand to improve in this area.

@steveklabnik steveklabnik added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. and removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-docs labels Feb 2, 2015
@steveklabnik
Copy link
Member

I don't forsee this getting fixed in rustdoc. Once we get type level integers, this will just go away, and until then, it's a bit gross, but other languages have basically the same issue.

It seems like I might be alone here, so I'll leave this open, but I'm really tempted to just close as WONTFIX.

@steveklabnik
Copy link
Member

Triage: no comments in a year. I feel the same as I did then; this isn't really a rustdoc-level thing to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants