Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trivial duplicate code paths are not always merged #26496

Closed
Tobba opened this issue Jun 22, 2015 · 7 comments
Closed

Trivial duplicate code paths are not always merged #26496

Tobba opened this issue Jun 22, 2015 · 7 comments
Labels
A-codegen Area: Code generation A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.

Comments

@Tobba
Copy link
Contributor

Tobba commented Jun 22, 2015

Long winded test case using libcore: (build with --crate-type staticlib and --emit asm)

#![feature(no_std, lang_items, asm, core)]
#![no_std]

use core::fmt;

#[macro_use]
extern crate core;

#[lang="panic_fmt"]
extern fn panic_fmt(msg: &fmt::Arguments, file: &'static str, line: u32) -> ! {
    loop { }
}

#[lang="stack_exhausted"]
extern fn stack_exhausted() {
    loop { }
}

#[lang="eh_personality"]
extern fn eh_personality() {
    loop { }
}

#[inline(always)]
fn foo() {
    panic!("Das Ist Nümberwang!");
}

fn black_box<T>(mut value: T) -> T {
    unsafe {
        asm!("" :: "r"(&mut value) :: "volatile");
    }
    value
}

pub fn main() {
    match black_box(5) {
        1 => foo(),
        48 => foo(),
        92 => foo(),
        23 => foo(),
        4 => foo(),
        70 => foo(),
        29 => foo(),
        36 => foo(),
        34 => foo(),
        58 => foo(),
        _ => { }
    }
}

This duplicates the following 3 times in the resulting code:

    leaq    _ZN3foo14_MSG_FILE_LINE20h7545777ae10911d4MaaE(%rip), %rdi
    callq   _ZN9panicking5panic20hefc2bd49b5114e0db7BE@PLT

This may not seem too bad, but in real world cases you can end up with something on the order of this: https://gist.github.com/Tobba/ab10d5644d3d4ef97917
@arielb1
Copy link
Contributor

arielb1 commented Jun 22, 2015

LLVM IR?

@arielb1
Copy link
Contributor

arielb1 commented Jun 22, 2015 

; ModuleID = 'rust_out.0.rs'
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"

%str_slice = type { i8*, i64 }

@vtable895 = internal unnamed_addr constant { void (i8*)*, i64, i64, i64 (%str_slice*)* } { void (i8*)* @_ZN2i88drop.87717h403a8fc59605337eE, i64 16, i64 8, i64 (%str_slice*)* @_ZN3any5T.Any11get_type_id21h11409169050976825453E }
@str896 = internal constant [20 x i8] c"Das Ist N\C3\BCmberwang!"
@str898 = internal constant [6 x i8] c"<anon>"
@_ZN3foo10_FILE_LINE20h45522c5a40a253aeqaaE = internal constant { %str_slice, i32, [4 x i8] } { %str_slice { i8* getelementptr inbounds ([6 x i8], [6 x i8]* @str898, i32 0, i32 0), i64 6 }, i32 5, [4 x i8] undef }

; Function Attrs: cold noinline noreturn uwtable
define internal fastcc void @_ZN2rt6unwind12begin_unwind21h14189931576037793481E() unnamed_addr #0 {
entry-block:
  %0 = tail call i8* @je_mallocx(i64 16, i32 0)
  %1 = icmp eq i8* %0, null
  br i1 %1, label %then-block-161-.i.i, label %"_ZN5boxed12Box$LT$T$GT$3new21h15424197560860407752E.exit"

then-block-161-.i.i:                              ; preds = %entry-block
  tail call void @_ZN3oom20hd47d86e88c71d41b96aE()
  unreachable

"_ZN5boxed12Box$LT$T$GT$3new21h15424197560860407752E.exit": ; preds = %entry-block
  %x.sroa.0.0..sroa_idx.i = bitcast i8* %0 to i8**
  store i8* getelementptr inbounds ([20 x i8], [20 x i8]* @str896, i64 0, i64 0), i8** %x.sroa.0.0..sroa_idx.i, align 8
  %x.sroa.4.0..sroa_idx2.i = getelementptr inbounds i8, i8* %0, i64 8
  %2 = bitcast i8* %x.sroa.4.0..sroa_idx2.i to i64*
  store i64 20, i64* %2, align 8
  tail call void @_ZN2rt6unwind18begin_unwind_inner20h30a8282e6074626cKPwE(i8* noalias nonnull %0, void (i8*)** nonnull getelementptr inbounds ({ void (i8*)*, i64, i64, i64 (%str_slice*)* }, { void (i8*)*, i64, i64, i64 (%str_slice*)* }* @vtable895, i64 0, i32 0), { %str_slice, i32 }* noalias readonly dereferenceable(24) bitcast ({ %str_slice, i32, [4 x i8] }* @_ZN3foo10_FILE_LINE20h45522c5a40a253aeqaaE to { %str_slice, i32 }*))
  unreachable
}

; Function Attrs: nounwind
declare void @llvm.lifetime.start(i64, i8* nocapture) unnamed_addr #1

; Function Attrs: cold noinline noreturn
declare void @_ZN2rt6unwind18begin_unwind_inner20h30a8282e6074626cKPwE(i8* noalias nonnull, void (i8*)** nonnull, { %str_slice, i32 }* noalias readonly dereferenceable(24)) unnamed_addr #2

; Function Attrs: nounwind
declare void @llvm.lifetime.end(i64, i8* nocapture) unnamed_addr #1

declare noalias i8* @je_mallocx(i64, i32) unnamed_addr #3

; Function Attrs: cold noinline noreturn
declare void @_ZN3oom20hd47d86e88c71d41b96aE() unnamed_addr #2

; Function Attrs: nounwind readnone
define internal void @_ZN2i88drop.87717h403a8fc59605337eE(i8* nocapture) unnamed_addr #4 {
entry-block:
  ret void
}

; Function Attrs: nounwind readnone uwtable
define internal i64 @_ZN3any5T.Any11get_type_id21h11409169050976825453E(%str_slice* noalias nocapture readonly dereferenceable(16)) unnamed_addr #5 {
entry-block:
  ret i64 8802261786977977801
}

; Function Attrs: uwtable
define internal void @_ZN4main20h84a5f37e14972344RaaE() unnamed_addr #6 {
entry-block:
  %value.i = alloca i32, align 4
  %0 = bitcast i32* %value.i to i8*
  call void @llvm.lifetime.start(i64 4, i8* %0) #7
  store i32 5, i32* %value.i, align 4
  call void asm sideeffect "", "r,~{dirflag},~{fpsr},~{flags}"(i32* nonnull %value.i) #7, !srcloc !0
  %1 = load i32, i32* %value.i, align 4
  call void @llvm.lifetime.end(i64 4, i8* %0) #7
  switch i32 %1, label %join [
    i32 1, label %match_case
    i32 48, label %match_case11
    i32 92, label %match_case12
    i32 23, label %match_case13
    i32 4, label %match_case14
    i32 70, label %match_case15
    i32 29, label %match_case16
    i32 36, label %match_case17
    i32 34, label %match_case18
    i32 58, label %match_case19
  ]

match_case:                                       ; preds = %entry-block
  call fastcc void @_ZN2rt6unwind12begin_unwind21h14189931576037793481E()
  unreachable

match_case11:                                     ; preds = %entry-block
  call fastcc void @_ZN2rt6unwind12begin_unwind21h14189931576037793481E()
  unreachable

match_case12:                                     ; preds = %entry-block
  call fastcc void @_ZN2rt6unwind12begin_unwind21h14189931576037793481E()
  unreachable

match_case13:                                     ; preds = %entry-block
  call fastcc void @_ZN2rt6unwind12begin_unwind21h14189931576037793481E()
  unreachable

match_case14:                                     ; preds = %entry-block
  call fastcc void @_ZN2rt6unwind12begin_unwind21h14189931576037793481E()
  unreachable

match_case15:                                     ; preds = %entry-block
  call fastcc void @_ZN2rt6unwind12begin_unwind21h14189931576037793481E()
  unreachable

match_case16:                                     ; preds = %entry-block
  call fastcc void @_ZN2rt6unwind12begin_unwind21h14189931576037793481E()
  unreachable

match_case17:                                     ; preds = %entry-block
  call fastcc void @_ZN2rt6unwind12begin_unwind21h14189931576037793481E()
  unreachable

match_case18:                                     ; preds = %entry-block
  call fastcc void @_ZN2rt6unwind12begin_unwind21h14189931576037793481E()
  unreachable

match_case19:                                     ; preds = %entry-block
  call fastcc void @_ZN2rt6unwind12begin_unwind21h14189931576037793481E()
  unreachable

join:                                             ; preds = %entry-block
  ret void
}

define i64 @main(i64, i8**) unnamed_addr #3 {
top:
  %2 = tail call i64 @_ZN2rt10lang_start20hdadb5fc58c5eeff334wE(i8* bitcast (void ()* @_ZN4main20h84a5f37e14972344RaaE to i8*), i64 %0, i8** %1)
  ret i64 %2
}

declare i64 @_ZN2rt10lang_start20hdadb5fc58c5eeff334wE(i8*, i64, i8**) unnamed_addr #3

attributes #0 = { cold noinline noreturn uwtable "split-stack" }
attributes #1 = { nounwind "split-stack" }
attributes #2 = { cold noinline noreturn "split-stack" }
attributes #3 = { "split-stack" }
attributes #4 = { nounwind readnone "split-stack" }
attributes #5 = { nounwind readnone uwtable "split-stack" }
attributes #6 = { uwtable "split-stack" }
attributes #7 = { nounwind }

!0 = !{i32 4}

@arielb1
Copy link
Contributor

arielb1 commented Jun 22, 2015

This seems like an LLVM issue (maybe it tries to preserve traceback line numbers? Still happens when intrinsics::abort is used through).

@arielb1 arielb1 added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-codegen Area: Code generation labels Jun 22, 2015
@dylanmckay
Copy link
Contributor

The problem is that LLVM does not implement duplicate basic block merging (see bug 24220).

I have written a pass (and in the process of submitting it) which correctly deduplicates switch case blocks if they are identical, which correctly reduces the example code above into a single basic block.

@dylanmckay
Copy link
Contributor

An even shorter reproduction case:

declare void @foo();

; Function Attrs: uwtable
define external void @main() unnamed_addr #6 {
entry-block:
  %value.i = alloca i32, align 4
  %0 = bitcast i32* %value.i to i8*
  store i32 5, i32* %value.i, align 4

  call void asm "", "r,~{dirflag},~{fpsr},~{flags}"(i32* nonnull %value.i) #7

  %1 = load i32, i32* %value.i, align 4
  switch i32 %1, label %join [
    i32 1, label %match_case
    i32 48, label %match_case11
    i32 92, label %match_case12
    i32 23, label %match_case13
    i32 4, label %match_case14
    i32 70, label %match_case15
    i32 29, label %match_case16
    i32 36, label %match_case17
    i32 34, label %match_case18
    i32 58, label %match_case19
  ]

match_case:                                       ; preds = %entry-block
  call void @foo()
  unreachable

match_case11:                                     ; preds = %entry-block
  call void @foo()
  unreachable

match_case12:                                     ; preds = %entry-block
  call void @foo()
  unreachable

match_case13:                                     ; preds = %entry-block
  call void @foo()
  unreachable

match_case14:                                     ; preds = %entry-block
  call void @foo()
  unreachable

match_case15:                                     ; preds = %entry-block
  call void @foo()
  unreachable

match_case16:                                     ; preds = %entry-block
  call void @foo()
  unreachable

match_case17:                                     ; preds = %entry-block
  call void @foo()
  unreachable

match_case18:                                     ; preds = %entry-block
  call void @foo()
  unreachable

match_case19:                                     ; preds = %entry-block
  call void @foo()
  unreachable

join:                                             ; preds = %entry-block
  ret void
}

@dylanmckay dylanmckay mentioned this issue Dec 30, 2015
Closed
@ranma42
Copy link
Contributor

ranma42 commented Dec 31, 2015

This problem affects the Eq code for enums as per comments in #13623

@Mark-Simulacrum
Copy link
Member

With rustc --crate-type lib --emit asm -O, the leaq is only seen once in the output. Closing as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ranma42 @Tobba @arielb1 @Mark-Simulacrum @dylanmckay