Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows linker regression in 1.6 #31151

Closed
brson opened this issue Jan 23, 2016 · 2 comments
Closed

Windows linker regression in 1.6 #31151

brson opened this issue Jan 23, 2016 · 2 comments
Labels
O-windows Operating system: Windows P-low Low priority regression-from-stable-to-stable Performance or correctness regression from one stable version to another.

Comments

@brson
Copy link
Contributor

brson commented Jan 23, 2016

As reported here.

I had a problem after upgrading from 1.5 (stable) to 1.6 (stable), so I thought I'd document the fix here. My system is Windows 10, 64-bit; Rust compiler is MSVC ABI; Visual Studio 13 Express for Desktop is installed.

After upgrading, all cargo builds failed with "link.exe could not find ws2_32.lib". The problem was that the LIB path wasn't set. Setting the environment variable LIB to:

"C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\lib\amd64"; "C:\Program Files (x86)\Windows Kits\8.1\Lib\winv6.3\um\x64" fixed the problem. Your paths may vary, of course, and you might have to add other paths if you have other missing libraries.

I'm not sure why this worked with earlier versions of Rust; it seems like it should always have failed.

@retep998 Do you know what we should change to make this work out of the box again?

@brson brson added I-nominated regression-from-stable-to-stable Performance or correctness regression from one stable version to another. labels Jan 23, 2016
@retep998
Copy link
Member

I have some ideas of what to do that I got after interrogating a different person on IRC about their issues. I will put together a PR that makes that code even more robust.

@alexcrichton
Copy link
Member

triage: P-low

@rust-highfive rust-highfive added P-low Low priority and removed I-nominated labels Feb 11, 2016
@huonw huonw added the O-windows Operating system: Windows label May 4, 2016
@bors bors closed this as completed in a1b33b4 Jul 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-windows Operating system: Windows P-low Low priority regression-from-stable-to-stable Performance or correctness regression from one stable version to another.
Projects
None yet
Development

No branches or pull requests

5 participants