Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#[target_feature="±<feat>"] is not properly checked against whitelist #38900

Closed
nagisa opened this issue Jan 7, 2017 · 3 comments
Closed

#[target_feature="±<feat>"] is not properly checked against whitelist #38900

nagisa opened this issue Jan 7, 2017 · 3 comments
Labels
A-simd Area: SIMD (Single Instruction Multiple Data) C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@nagisa
Copy link
Member

nagisa commented Jan 7, 2017

#[cfg(target_feature="abcd")] was landed with a strong requirement to have a whitelist of LLVM features that are exposed this way, mostly due to compatibility concerns with LLVM.

#[target_feature="±abcd"], however does not check against the whitelist in question and allows everything through. Seems like a potential compat footgun?
@est31
Copy link
Member

est31 commented Jan 7, 2017

cc @BurntSushi

@BurntSushi
Copy link
Member

It was landed to make it possible to experiment with SIMD support in Rust. I would expect this question to be resolved in the stabilization effort. (But yes, I agree, it does certainly need to be checked.)

@nagisa nagisa mentioned this issue Apr 18, 2017
Closed
1 task
@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jun 23, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-bug Category: This is a bug. label Jul 26, 2017
@alexcrichton alexcrichton added the A-simd Area: SIMD (Single Instruction Multiple Data) label Sep 25, 2017
@alexcrichton
Copy link
Member

This was fixed for #44839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-simd Area: SIMD (Single Instruction Multiple Data) C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alexcrichton @BurntSushi @nagisa @Mark-Simulacrum @est31