Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rustc_trans::abi not to use LLVM #39617

Closed
arielb1 opened this issue Feb 7, 2017 · 3 comments
Closed

Refactor rustc_trans::abi not to use LLVM #39617

arielb1 opened this issue Feb 7, 2017 · 3 comments
Assignees
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@arielb1
Copy link
Contributor

arielb1 commented Feb 7, 2017

Currently, rustc_trans::abi uses LLVM, which makes it hard to use from alternate back-ends like Cranelift. If we refactor it to a separate crate that only relies on ty::layout, that would make life easierr.

cc @eddyb.
cc @camlorn - you might be interested in it.

@ahicks92
Copy link
Contributor

ahicks92 commented Feb 7, 2017

This seems like a good idea but also like a really huge project, so have fun with it.

I'm not actually sure what all that module does. My work barely touched it. I doubt I'll be much use here, but I'll certainly monitor. One thing that would be nice to have (and that this may help with) is a C backend, which would have potential uses for things like integrating with Python (which can only compile C). Maybe someone already did that, though.

@eddyb eddyb self-assigned this Mar 5, 2017
@eddyb
Copy link
Member

eddyb commented Mar 23, 2017

Most of it is in #40658 already, but I want to keep this issue open for tracking the move to a different crate.
I'm pretty sure we can do it by having generics over the Ty in TyLayout (and/or the context type), but keep Layout fully defined outside of librustc.

@Mark-Simulacrum Mark-Simulacrum added C-cleanup Category: PRs that clean code up or issues documenting cleanup. and removed A-refactor labels Jul 24, 2017
@eddyb
Copy link
Member

eddyb commented Jul 13, 2018

This was finished by #50228.

@eddyb eddyb closed this as completed Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests

4 participants