Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible compile-time regression #47742

Closed
nikomatsakis opened this issue Jan 25, 2018 · 6 comments
Closed

possible compile-time regression #47742

nikomatsakis opened this issue Jan 25, 2018 · 6 comments
Assignees
Labels
I-compiletime Issue: Problems and improvements with respect to compile times. P-high High priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nikomatsakis
Copy link
Contributor

According to perf.rust-lang.org, rollup commit 51b0b37 seems to have caused a big jump in the "Summary" numbers. However, scrolling down through the individual tests, we don't see that same jump mirrored anywhere else. Moreover, clicking on the commit in question doesn't give the usual test-by-test breakdown, just an empty page. I'm guessing this is some sort of fluke, but it'd be great to have that confirmed.

(Also, what exactly do the summary numbers represent, anyway?)

cc @Mark-Simulacrum @rust-lang/compiler @rust-lang/infra

@nikomatsakis nikomatsakis added I-compiletime Issue: Problems and improvements with respect to compile times. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 25, 2018
@nikomatsakis
Copy link
Contributor Author

triage: P-high

We need to know what happened.

@rust-highfive rust-highfive added the P-high High priority label Jan 25, 2018
@kennytm
Copy link
Member

kennytm commented Jan 25, 2018

This is likely just rust-lang/rustc-perf#178. Nothing to see here, move along.

@nikomatsakis
Copy link
Contributor Author

Should we close? How "likely" :)

@kennytm
Copy link
Member

kennytm commented Jan 25, 2018

Very likely given the commit hash, but I'll let @Mark-Simulacrum confirm ☺️

@Mark-Simulacrum Mark-Simulacrum self-assigned this Jan 25, 2018
@Mark-Simulacrum
Copy link
Member

I'll investigate. Assigned myself.

@Mark-Simulacrum
Copy link
Member

We weren't compiling crates.io in either release or debug mode because ring failed to compile, after #47298 was merged in the rollup PR crates.io began compiling, and so the summary numbers jumped up. I'm going to close this issue as nothing to be worried about. I'm working on a patch that'll allow this to be more visible in the compare view (instead of just breaking).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-compiletime Issue: Problems and improvements with respect to compile times. P-high High priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants