Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incr.comp.: Allow for re-using object files that contain unused code. #48212

Open
michaelwoerister opened this issue Feb 14, 2018 · 1 comment
Labels
A-incr-comp Area: Incremental compilation C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@michaelwoerister
Copy link
Member

Right now, incremental compilation can only re-use an object file if it is an exact match of that code that we want. In theory it would be possible though to keep using an object file that contains a superset of the code we need.

An implementation would probably need #48211 to be implemented first. CGU translation would also need to be de-querified since the re-use decision cannot be made by simply marking the CGU as green.

However, before putting effort into implementing this we should make sure that it would actually pay off. For this we need to collect some data on MonoItem invalidation (which again is covered by #48211).

@michaelwoerister michaelwoerister added the A-incr-comp Area: Incremental compilation label Feb 14, 2018
@XAMPPRocky XAMPPRocky added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 26, 2018
@steveklabnik
Copy link
Member

Triage: I don't know anything about the details here, but I assume this was never gotten to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-incr-comp Area: Incremental compilation C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants