Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiletest: //~ ERROR should be interpreted as applying to all revisions #56279

Closed
pnkfelix opened this issue Nov 27, 2018 · 2 comments
Closed
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@pnkfelix
Copy link
Member

Spawned off of https://github.com/rust-lang/rust/pull/56244/files#r236635792

Right now, you have to write explicit //[rev]~ ERROR annotations for each revision rev in a given test. This is true even when all of the revisions can use identical annotations.

We should change compiletest so that occurrences of //~ ERROR are still parsed and are treated as synonymous for a copy of that same annotation for every revision in the // revisions: set.

@oli-obk
Copy link
Contributor

oli-obk commented Nov 27, 2018

In some situations it would also have been nice to be able to specify a set of revisions like //[revA revB]~ ERROR.

@estebank estebank added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jan 11, 2019
@tmiasko
Copy link
Contributor

tmiasko commented Feb 1, 2022

Since #66524 //~ ERROR applies to all revisions, and //[A,B]~ ERROR to revisions A and B.

@tmiasko tmiasko closed this as completed Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Development

No branches or pull requests

4 participants