mismatched types with from_le_bytes

[Mark-Simulacrum]

https://crater-reports.s3.amazonaws.com/beta-1.32-1/beta-2018-12-05/reg/tinkerforge-2.0.5/log.txt

Dec 10 00:57:00.056 INFO [stderr] error[E0308]: mismatched types
Dec 10 00:57:00.056 INFO [stderr]   --> src/bindings/accelerometer_bricklet.rs:92:48
Dec 10 00:57:00.056 INFO [stderr]    |
Dec 10 00:57:00.056 INFO [stderr] 92 |         Acceleration { x: <i16>::from_le_bytes(&bytes[0..2]), y: <i16>::from_le_bytes(&bytes[2..4]), z: <i16>::from_le_bytes(&bytes[4..6]) }
Dec 10 00:57:00.056 INFO [stderr]    |                                                ^^^^^^^^^^^^ expected array of 2 elements, found &[u8]
Dec 10 00:57:00.056 INFO [stderr]    |
Dec 10 00:57:00.056 INFO [stderr]    = note: expected type `[u8; 2]`
Dec 10 00:57:00.056 INFO [stderr]               found type `&[u8]`
Dec 10 00:57:00.056 INFO [stderr] 
Dec 10 00:57:00.096 INFO [stderr] error[E0308]: mismatched types
Dec 10 00:57:00.096 INFO [stderr]   --> src/bindings/accelerometer_bricklet.rs:92:87
Dec 10 00:57:00.096 INFO [stderr]    |
Dec 10 00:57:00.096 INFO [stderr] 92 |         Acceleration { x: <i16>::from_le_bytes(&bytes[0..2]), y: <i16>::from_le_bytes(&bytes[2..4]), z: <i16>::from_le_bytes(&bytes[4..6]) }
Dec 10 00:57:00.096 INFO [stderr]    |                                                                                       ^^^^^^^^^^^^ expected array of 2 elements, found &[u8]
Dec 10 00:57:00.096 INFO [stderr]    |
Dec 10 00:57:00.096 INFO [stderr]    = note: expected type `[u8; 2]`
Dec 10 00:57:00.096 INFO [stderr]               found type `&[u8]`
Dec 10 00:57:00.096 INFO [stderr] 
Dec 10 00:57:00.140 INFO [stderr] error[E0308]: mismatched types
Dec 10 00:57:00.140 INFO [stderr]   --> src/bindings/accelerometer_bricklet.rs:92:126
Dec 10 00:57:00.140 INFO [stderr]    |
Dec 10 00:57:00.140 INFO [stderr] 92 |         Acceleration { x: <i16>::from_le_bytes(&bytes[0..2]), y: <i16>::from_le_bytes(&bytes[2..4]), z: <i16>::from_le_bytes(&bytes[4..6]) }
Dec 10 00:57:00.140 INFO [stderr]    |                                                                                                                              ^^^^^^^^^^^^ expected array of 2 elements, found &[u8]
Dec 10 00:57:00.140 INFO [stderr]    |
Dec 10 00:57:00.140 INFO [stderr]    = note: expected type `[u8; 2]`
Dec 10 00:57:00.140 INFO [stderr]               found type `&[u8]`

[alexcrichton]

cc @rust-lang/libs, this is a regression from #56207, tracking the issue #52963. We added from_le_bytes inherent methods to integer types, and they're shadowing trait-based methods that were presumably already in scope.

Also cc @rtrbt as you're listed as the owner of this crate on crates.io, good to give you a heads up!

[SimonSapin]

This seems like business as usual, unless we decide to never add new methods to existing language or standard library types.

[rtrbt]

I've fixed it on my end. Thank you for ccing.

[alexcrichton]

Thanks for the heads up @rtrbt!

I'm going to preemptively close this as mentioned by @SimonSapin this is a pretty standard change/breakage, but if others from libs disagree feel free to comment so!

If anyone runs into this into the wild and has difficulty upgrading and/or fixing the issue, also please comment here and let us know!