Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc should use vendor names for target features #61895

Closed
newpavlov opened this issue Jun 16, 2019 · 1 comment
Closed

rustc should use vendor names for target features #61895

newpavlov opened this issue Jun 16, 2019 · 1 comment
Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@newpavlov
Copy link
Contributor

Right now in source code we follow vendor names and not LLVM ones (e.g. rdrand and not rdrnd). Translation is handled here. But when enabling target feature via rustc flags we have to use LLVM names, i.e. -C target-feature=+rdrnd and +rdrand will not work. So we have inconsistency on our hands.

At the very least vendor names provided in rustc flags should be translated to LLVM ones. Additionally I think we should not expose LLVM names at all, including in rustc --print target-features.

Relevant: #50077, #48369
@newpavlov newpavlov mentioned this issue Jun 16, 2019
Merged
@jonas-schievink jonas-schievink added A-driver Area: rustc_driver that ties everything together into the `rustc` compiler C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 16, 2019
@hanna-kruppe
Copy link
Contributor

cf. #49653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@newpavlov @jonas-schievink @hanna-kruppe