Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustfmt no longer builds after rust-lang/rust#74653 #74812

Closed
rust-highfive opened this issue Jul 27, 2020 · 3 comments · Fixed by #75427
Closed

rustfmt no longer builds after rust-lang/rust#74653 #74812

rust-highfive opened this issue Jul 27, 2020 · 3 comments · Fixed by #75427
Assignees
Labels
A-rustfmt Area: Rustfmt C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #74653, I observed that the tool rustfmt no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rustfmt is needed to fix the fallout.

cc @petrochenkov, do you think you would have time to do the follow-up work?
If so, that would be great!

And nominating for compiler team prioritization.

@calebcartwright
Copy link
Member

calebcartwright commented Aug 5, 2020

A bump of the rustc-ap crates in rustfmt is required to address this.

Note that the rustc-ap bumps in racer and rustfmt can be done in parallel, the remaining tasks have to be sequenced

@branan
Copy link

branan commented Aug 11, 2020

Are there additional issues/complications that are blocking this? I bumped rustfmt/racer locally and rls seems to build - I'd be happy to open PRs if that's all it takes to get this green again

@calebcartwright
Copy link
Member

It's my understanding that @Xanewok is already working on step 2 (updating the references in rls). I can't really speak to what's going on in rls, which branch is planned/whether there's other commits to be included/etc. You may want to ask directly in rust-lang/rls or on #74811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustfmt Area: Rustfmt C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants