Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miri no longer builds after rust-lang/rust#75436 #75441

Closed
rust-highfive opened this issue Aug 12, 2020 · 5 comments · Fixed by #75478
Closed

miri no longer builds after rust-lang/rust#75436 #75441

rust-highfive opened this issue Aug 12, 2020 · 5 comments · Fixed by #75478
Assignees
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #75436, I observed that the tool miri no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @JohnTitor, do you think you would have time to do the follow-up work?
If so, that would be great!

And nominating for compiler team prioritization.

@rust-highfive rust-highfive added A-miri Area: The miri tool C-bug Category: This is a bug. labels Aug 12, 2020
@JohnTitor
Copy link
Member

Here's the fix by oli: rust-lang/miri#1507

@camelid
Copy link
Member

camelid commented Aug 13, 2020

It looks like the PR is merged. Should this issue be closed or are there further steps to complete until it's fully fixed?

@JohnTitor
Copy link
Member

It looks like the PR is merged. Should this issue be closed or are there further steps to complete until it's fully fixed?

The submodule should be updated to fix toolstate.

@camelid
Copy link
Member

camelid commented Aug 13, 2020

Thanks! I'm trying to understand the protocol around tool breakages, so I was trying to understand why the issue wasn't yet closed :)

@RalfJung
Copy link
Member

I'll get rust-lang/miri#1504 into Miri and then submit a submodule update that will close this issue. :)

I often wait a bit after Miri is fixed before doing the submodule update, to collect more things into the same update. It's okay when Miri is missing for a few days.

@RalfJung RalfJung mentioned this issue Aug 13, 2020
@bors bors closed this as completed in 3fbed17 Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants