Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

size: metrics vs Artefact size #1679

Open
fbstj opened this issue Jul 28, 2023 · 1 comment
Open

size: metrics vs Artefact size #1679

fbstj opened this issue Jul 28, 2023 · 1 comment

Comments

@fbstj
Copy link

fbstj commented Jul 28, 2023

is there any plans/scope for "extracting" the size: metrics out from under the "compile-time" header now that there's a grouping for artefact sizes?

or am I entirely missing the point?

@Kobzol
Copy link
Contributor

Kobzol commented Jul 28, 2023

Hi, these two things represent slightly different things, but it's not so intuitive to understand that at the moment. In theory, it could be unified, but probably it's not worth it (see below).

The size: metrics contain the sizes of crates compiled by rustc. It contains metadata sizes, binary executable sizes, etc., for crates like syn or serde. This size if affected by changes that we make to the logic of rustc.

The "artifact size" tab contains the size of the Rust compiler binaries and libraries. So what is the size of the compiler itself. This size is affected by changes that we make to the logic of rustc (because rustc is compiled by rustc :) ), but also by changes that we make to the way we build and distribute rustc, and also unrelated things (e.g. the way we build and distribute LLVM).

Since the size: metrics belong to the compilation benchmarks, I suppose that it makes sense to group them with the other metrics (like instruction count or wall-time). The compiler artifact sizes are totally separate and they wouldn't really fit within the compilation benchmark table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants