Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod statements are ordered ASCIIbetically #3242

Closed
KamilaBorowska opened this issue Dec 10, 2018 · 2 comments
Closed

mod statements are ordered ASCIIbetically #3242

KamilaBorowska opened this issue Dec 10, 2018 · 2 comments

Comments

@KamilaBorowska
Copy link

KamilaBorowska commented Dec 10, 2018

https://gitlab.com/KonradBorowski/advent-of-code-2018/commit/cd9f8773de229b8fd6356e6c722d0ef55173f809

diff --git a/src/main.rs b/src/main.rs
index 090e2e1..f147489 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -3,6 +3,7 @@ use std::io::{self, Read, Write};
 use structopt::StructOpt;

 mod day1;
+mod day10;
 mod day2;
 mod day3;
 mod day4;
@@ -11,7 +12,6 @@ mod day6;
 mod day7;
 mod day8;
 mod day9;
-mod day10;
 #[cfg(test)]
 mod testmacros;

I think it would be better to use natural ordering.

@KamilaBorowska KamilaBorowska changed the title mod statements are ordered ASCII-betically mod statements are ordered ASCIIbetically Dec 10, 2018
@topecongiro
Copy link
Contributor

IMHO this hardly ever occurs in practice but the implementation cost is pretty high, so I am going to mark this as won't fix. Sorry.

@KamilaBorowska
Copy link
Author

Fixed by #3764.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants