Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should be do about the stdsimd feature? #461

Open
2 of 7 tasks
gnzlbg opened this issue May 24, 2018 · 2 comments
Open
2 of 7 tasks

What should be do about the stdsimd feature? #461

gnzlbg opened this issue May 24, 2018 · 2 comments

Comments

@gnzlbg
Copy link
Contributor

gnzlbg commented May 24, 2018

We are exposing a bunch of stuff from coresimd and everything is behind the same feature gate stdsimd:

core:

  • simd: should probably be behind its own feature name core_simd, portable_simd or similar

  • arch: is behind the simd_arch feature

    • x86: is behind the simd_x86 feature
    • x86_64: is behind the simd_x86 feature
    • arm/aarch64: should be behind the simd_arm feature
    • wasm32: simd_wasm? @alexcrichton
    • mips/mips64: should be behind the simd_mips feature
    • powerpc/powerpc64: should be behind the simd_ppc feature

Also, the nvptx module is not exposed anymore. I can't recall the exact reason but remember that there was one. In any case, should we add some feature name for it (e.g. nvptx_arch) and expose it again?


Also, some of the tracking issues for these things are in the stdsimd repo, do we need to open issues in rust-lang/rust for them ?

For the core::simd issue I think it's ok to keep it pointing to the tracking issue of the original RFC by @huonw .

@alexcrichton
Copy link
Member

Sure yeah seems fine by me to move them behind per-platform features, they're likely to stabilize per-platform anyway!

@lu-zero
Copy link
Contributor

lu-zero commented May 24, 2018

Add #463 and #462 for Altivec and VSX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants