Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rand_chacha::ChaCha20Core does not implement CryptoRng #943

Closed
coltfred opened this issue Mar 5, 2020 · 2 comments · Fixed by #944
Closed

rand_chacha::ChaCha20Core does not implement CryptoRng #943

coltfred opened this issue Mar 5, 2020 · 2 comments · Fixed by #944

Comments

@coltfred
Copy link
Contributor

coltfred commented Mar 5, 2020

It seems that all of the ChaChaXCore structs are missing their CryptoRng impls. This makes it impossible to construct a ReseedingRng from them which is itself CryptoRng.

Is this a mistake? Am I missing something? I'd be happy to PR it if it would be welcome.
@dhardy
Copy link
Member

dhardy commented Mar 6, 2020

Yes, I think this is probably an oversight.

@coltfred coltfred mentioned this issue Mar 7, 2020
Merged
@coltfred
Copy link
Contributor Author

coltfred commented Mar 7, 2020

@dhardy I've opened #944 to add the marker trait.

Let me know if there's anything else you need from me in regards to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CryptoRng marker trait to ChaChaXCore coltfred/rand
2 participants
@dhardy @coltfred