Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Victor mono complete's italic ligatures are buggered #494

Closed
GTMxCode opened this issue Jun 20, 2020 · 6 comments
Closed

Victor mono complete's italic ligatures are buggered #494

GTMxCode opened this issue Jun 20, 2020 · 6 comments

Comments

@GTMxCode
Copy link

Hey started using a bunch of these cause I got sick of FF crashing when making my own, thanks for all the work.

I did notice that the victor mono fonts from the "victor mono complete mono" branch are messed up in the italic variants above 500 weight. I havnt opened this particular font up, but I did notice a few of the others which had a random computer screen glyph unioned with random other glyphs from another lang set... Either way I'm pretty sure the tables got dickered and things like
See: Imgur

Thats VSCode you see. I tested in Hyper as well, but also in windows new terminal and they all showed the same (and win terminal really dicks with fonts good). Tried all weights and as I said above 500 its good, which seems strange but I guess there must be some oddity/gremlin causing it

take it easy!

@lfom
Copy link

lfom commented Aug 4, 2020

The problem seems to be the ligatures for Latin letters at the end of the file. For some reason, even tho Victor Mono is already a mono-spaced font, the font-patcher is changing the font when using the --mono toggle. The weird thing is that the Bold Italics works fine...
Anyway, as a workaround you can either copy the characters from the non-Mono font (and to be very precise also change their width afterwards to 601), or delete them (you will lose those ligtures, of course).

@mbirth
Copy link

mbirth commented Jul 9, 2021

On a sidenote, MacOS seems to think all italic variants are the same. It doesn't differentiate between the various weights and instead suggests to delete all but one. Same for all the Oblique variants. No problem with the non-italic variants, though.

@McAllaster
Copy link

On a sidenote, MacOS seems to think all italic variants are the same. It doesn't differentiate between the various weights and instead suggests to delete all but one. Same for all the Oblique variants. No problem with the non-italic variants, though.

Looks like that is similar to #257

@tienbuigia
Copy link

a workaround for me is using Victor Mono before the nerd's one
example

@Finii
Copy link
Collaborator

Finii commented May 5, 2023

Fixed in 3.0.0 at least

image

Edit: Note: ProggyClean is just a test text from the original Issue image

@Finii Finii closed this as completed May 5, 2023
Copy link
Contributor

github-actions bot commented Nov 6, 2023

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants