Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking in container restores overflow: auto to element.style #23

Open
s6mike opened this issue Oct 5, 2022 · 4 comments
Open

Clicking in container restores overflow: auto to element.style #23

s6mike opened this issue Oct 5, 2022 · 4 comments
Labels
bug Something isn't working fixed in branch Fixed in branch but not master good first issue Good for newcomers

Comments

@s6mike
Copy link
Owner

s6mike commented Oct 5, 2022 •
edited
Loading

Thought I had fixed this by commenting out line 110 in mapjs/src/browser/dom-map-widget.js:

element.css('overflow', 'auto').attr('tabindex', 1);

Must be another piece of mapjs code updating it again.
@s6mike
Copy link
Owner Author

s6mike commented Oct 5, 2022

Introduced in v4.8.17 (12-argmapjs-fixes)

@s6mike s6mike added bug Something isn't working good first issue Good for newcomers labels Oct 5, 2022
@s6mike
Copy link
Owner Author

s6mike commented Oct 7, 2022

mapjs/src/browser/dom-map-widget.js:123 looks like it does this, have commented out and will commit around v4.9.1

@s6mike
Copy link
Owner Author

s6mike commented Oct 9, 2022 •
edited
Loading

When applying an earlier related fix (in v4.8.17) I also commented out the tabindex attribute, which is needed for sequential keyboard navigation, which stopped keyboard shortcuts working when clicking on the container (svg canvas). Fixed in v4.9.4.

@s6mike
Copy link
Owner Author

s6mike commented Oct 30, 2022

Fixed in argmap 4.9.1 (0c8d299)

@s6mike s6mike added the fixed in branch Fixed in branch but not master label Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fixed in branch Fixed in branch but not master good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s6mike