Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transactions Page] Inconsistent Display of Required Confirmations After Changing Threshold #1873

Open
OpenWJY opened this issue Aug 29, 2024 · 1 comment

Comments

@OpenWJY
Copy link

OpenWJY commented Aug 29, 2024

Description

After changing the Required Confirmations setting, the number of required confirmations displayed for pending transactions is inconsistent with the new setting.

Environment

  • Browser: Microsoft Edge
  • Wallet: MetaMask
  • Environment:
    • production

Steps to reproduce

  1. Assume the initial setting for Required Confirmations is 2 out of 5 signers.
  2. Initiate a transaction, let's call it Transaction A. Do not complete it; leave it in a pending confirmation state.
  3. Modify the Required Confirmations setting to 3 out of 5 signers. Confirm and execute this change.
  4. Observe that Transaction A still shows the old required confirmation count (2) instead of the new count (3).

Screenshots

I have highlighted the inconsistencies using red boxes in the attached image for clarity.

problem-simple

@katspaugh katspaugh transferred this issue from safe-global/safe-react-apps Aug 29, 2024
@katspaugh
Copy link
Member

Thanks! Forwarded to the backend team. cc @safe-global/safe-client-gateway-maintainers

@katspaugh katspaugh transferred this issue from safe-global/safe-wallet-web Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants