Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Script to check for removal of previous deployment types #687

Open
remedcu opened this issue Jul 9, 2024 · 0 comments
Open

Review Script to check for removal of previous deployment types #687

remedcu opened this issue Jul 9, 2024 · 0 comments

Comments

@remedcu
Copy link
Member

remedcu commented Jul 9, 2024

The current review script only checks for line changes, not the exact change in the deployment types.

So, if say there is an entry as:

    "someChainID": ["canonical", "eip155"]

then, if the PR removes one of the deployment types, it will still pass the review check.

    "someChainID": "canonical"

This issue is limited to v1.3.1.

Expected Outcome

To check the PR is not removing any current deployment types from the deployment list.

@remedcu remedcu changed the title Safe Deployment Review Script check for removal of previous chain Review Script to check for removal of previous deployment types Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant