Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Hide/show unknown" button in the history tab is not working #3334

Closed
francovenica opened this issue Feb 26, 2024 · 4 comments
Closed

"Hide/show unknown" button in the history tab is not working #3334

francovenica opened this issue Feb 26, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@francovenica
Copy link
Contributor

Bug description

The button is supposed to hide/show bogus tx's, but is not doing that when you click it

Environment

  • Browser: Chrome
  • Wallet: MetaMask
  • Chain: Ethereum mainnet

Steps to reproduce

  1. Go to this safe
  2. Filter by "incoming tx" so thelist show all the receivings tx (this safe has a lot of bogus tx of that kind)
  3. Use the "Hide/Show unknown" button

Expected result

bogus tx should be hidden/shown

Obtained result

The list just refreshes, nothing is hidden

Screenshots

hide tokens

@francovenica francovenica added the bug Something isn't working label Feb 26, 2024
@usame-algan usame-algan self-assigned this Feb 26, 2024
@usame-algan
Copy link
Member

Looked into this and I think the following endpoints on the CGW currently don't support the trusted flag:

  • incoming-transfers
  • multisig-transactions
  • module-transactions

We should evaluate if this is something thats possible to add on the CGW. cc @iamacook

For the time being, I suggest we hide the “Show/Hide unknown” button in the UI whenever a filter is applied.

@iamacook
Copy link
Member

Looked into this and I think the following endpoints on the CGW currently don't support the trusted flag:

* `incoming-transfers`

* `multisig-transactions`

* `module-transactions`

We should evaluate if this is something thats possible to add on the CGW. cc @iamacook

The trusted filtering on the history endpoint only affects incoming transfers so we can disregard multisig-transactions and module-transactions endpoints.

I've filed an issue regarding the implementation and we'll keep you informed.

@iamacook
Copy link
Member

A trusted query param. has been added to the incoming-transfers endpoint as of safe-global/safe-client-gateway#1214. I have also opened a PR adding it to the SDK.

@katspaugh
Copy link
Member

Cool, thanks! We'll need to pass that param in the filtered requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants