Skip to content
This repository has been archived by the owner on Nov 22, 2021. It is now read-only.

Don't highlight menus with key bindings when typing text into inputs #170

Open
jbergstroem opened this issue Aug 22, 2018 · 2 comments
Open

Comments

@jbergstroem
Copy link
Contributor

Key bindings (Repost, Like, ..) seems to be highlighted when using search or other input forms. The trigger should probably check for this before firing (seems to be purely cosmetic though, the actual repost or like action doesn't fire).

@salomvary
Copy link
Owner

There are measures taken not to trigger those key binding when typing inputs.

Avoiding menu item highlights is s little trickier. The problem is, shortcuts like "L for Like" are implemented on soundcloud.com itself, the shortcut on the menu item is only relevant when the main window does not have keyboard focus (minimized, in background, etc).

The proper solution would disable the menu shortcuts when the main window is focused and re-enable them on blur. I did not investigate whether this is doable with Electron or not, but a pull request to improve is always welcome.

@salomvary salomvary changed the title Don't trigger key bindings when using search forms Don't highlight menus with key bindings when typing text into inputs Aug 27, 2018
@jbergstroem
Copy link
Contributor Author

@salomvary said: I did not investigate whether this is doable with Electron or not, but a pull request to improve is always welcome.

I can't say I'm much better -- I don't know Electron well enough. I just thought it was worth to at least track the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants