Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal orientation issue #47

Open
markelsoft opened this issue Mar 27, 2013 · 0 comments
Open

Horizontal orientation issue #47

markelsoft opened this issue Mar 27, 2013 · 0 comments

Comments

@markelsoft
Copy link

Nice code but there is a bug when orientation switched to landscape. The view is not updated along with its thumbs.

the SVSegmentedControl setFrame method should also call [self updateSectionRects] to update the section rects which works fine except that new correct thumbrects are added also but to an existing array so if have 6 thumbrects , 6 new correct thumbrects are at the end of the array. self.thumbrects should removeAllObjects before addObject loop...

When an app calls setFrame in a landscape or portrait change to adjust the SVSegmentedControl size the the section fixes one thing and updates the control but not the thumbs (self.thumbrects). The loop in updateSectionRects does an addObject to self.thumbrects to add the correct new thumb rects, however, if self.thumbrects already exists a [self thumbrects removeAllObjects] should be called first otherwise keep adding rects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant