Skip to content
This repository has been archived by the owner on Nov 22, 2018. It is now read-only.
This repository has been archived by the owner on Nov 22, 2018. It is now read-only.

Won't work with libsass >= 3.5 #66

Open
lolmaus opened this issue Apr 21, 2016 · 1 comment
Open

Won't work with libsass >= 3.5 #66

lolmaus opened this issue Apr 21, 2016 · 1 comment

Comments

@lolmaus
Copy link
Contributor

lolmaus commented Apr 21, 2016

Yesterday (April 20), libsass 3.3.3 was released.

https://github.com/sass/libsass/releases
https://github.com/sass/node-sass/releases

Now sass-config-manager crashes with:

File: /path/to/project/node_modules/sass-config-manager/sass/_sass-config-manager.scss (357)
Undefined variable: "$sass-config-namespace"

It seems that it's now illegal to define variables inside an if clause.

To avoid the if clause, we could split the lib into two files: global and local. A user will have a choice which one to import.

@prisis
Copy link
Member

prisis commented Apr 25, 2016

Hey @lolmaus,

i will check it the evening and add a fix for it.

Or you like to make a pull request :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants