From cb9e3f36e167088367a681a0a6100b7c1396e11a Mon Sep 17 00:00:00 2001 From: double beep <38133098+double-beep@users.noreply.github.com> Date: Tue, 18 Jun 2024 12:42:58 +0000 Subject: [PATCH 1/3] feat!: drop EOL Node versions --- .github/workflows/alpine.yml | 2 -- .github/workflows/linux.yml | 8 -------- .github/workflows/macos.yml | 2 -- appveyor.yml | 6 ------ package.json | 2 +- 5 files changed, 1 insertion(+), 19 deletions(-) diff --git a/.github/workflows/alpine.yml b/.github/workflows/alpine.yml index 7aaf451dc..42fa879fd 100644 --- a/.github/workflows/alpine.yml +++ b/.github/workflows/alpine.yml @@ -15,9 +15,7 @@ jobs: fail-fast: false matrix: node: - - 16 - 18 - - 19 - 20 steps: diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index 3f8939cc1..1d002e4ed 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -14,18 +14,10 @@ jobs: fail-fast: false matrix: include: - - node: 16 - gcc: "gcc-8" - gpp: "g++-8" - os: ubuntu-20.04 - node: 18 gcc: "gcc-8" gpp: "g++-8" os: ubuntu-20.04 - - node: 19 - gcc: "gcc-8" - gpp: "g++-8" - os: ubuntu-20.04 - node: 20 gcc: "gcc-10" gpp: "g++-10" diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index 056e1cf3b..d3da8b5cd 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -14,9 +14,7 @@ jobs: fail-fast: false matrix: node: - - 16 - 18 - - 19 - 20 steps: diff --git a/appveyor.yml b/appveyor.yml index 17e95edc6..4aeb15ad8 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -33,15 +33,9 @@ environment: SKIP_SASS_BINARY_DOWNLOAD_FOR_CI: true matrix: - - nodejs_version: 16 - GYP_MSVS_VERSION: 2019 - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019 - nodejs_version: 18 GYP_MSVS_VERSION: 2019 APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019 - - nodejs_version: 19 - GYP_MSVS_VERSION: 2019 - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019 - nodejs_version: 20 GYP_MSVS_VERSION: 2019 APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019 diff --git a/package.json b/package.json index cb533412b..35d7100b6 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ "url": "http://andrew.github.com" }, "engines": { - "node": ">=16" + "node": "^18 || ^20" }, "main": "lib/index.js", "nodeSassConfig": { From 53b9aecf271da00d4bdc975aae77c8981dae5e0b Mon Sep 17 00:00:00 2001 From: double beep <38133098+double-beep@users.noreply.github.com> Date: Tue, 18 Jun 2024 13:04:05 +0000 Subject: [PATCH 2/3] chore: bump dependencies --- package.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index 35d7100b6..76770768a 100644 --- a/package.json +++ b/package.json @@ -60,19 +60,19 @@ "get-stdin": "^4.0.1", "glob": "^7.0.3", "lodash": "^4.17.15", - "make-fetch-happen": "^10.0.4", + "make-fetch-happen": "^13.0.1", "meow": "^9.0.0", "nan": "^2.17.0", "node-gyp": "^10.0.1", "sass-graph": "^4.0.1", - "stdout-stream": "^1.4.0", + "stdout-stream": "^2.0.0", "true-case-path": "^2.2.1" }, "devDependencies": { "eslint": "^8.0.0", - "fs-extra": "^10.0.0", - "mocha": "^9.0.1", - "nyc": "^15.1.0", + "fs-extra": "^11.2.0", + "mocha": "^10.4.0", + "nyc": "^17.0.0", "rimraf": "^3.0.2", "unique-temp-dir": "^1.0.0" } From 5de1307c0facbc2dab42327f84fa9fe8f22a9f57 Mon Sep 17 00:00:00 2001 From: double beep <38133098+double-beep@users.noreply.github.com> Date: Tue, 18 Jun 2024 14:13:45 +0000 Subject: [PATCH 3/3] feat: Node 22 support --- .github/workflows/alpine.yml | 1 + .github/workflows/linux.yml | 4 ++++ .github/workflows/macos.yml | 1 + .github/workflows/windows.yml | 3 +-- README.md | 4 ++-- appveyor.yml | 3 +++ lib/extensions.js | 1 + package.json | 2 +- 8 files changed, 14 insertions(+), 5 deletions(-) diff --git a/.github/workflows/alpine.yml b/.github/workflows/alpine.yml index 42fa879fd..47a689d9d 100644 --- a/.github/workflows/alpine.yml +++ b/.github/workflows/alpine.yml @@ -17,6 +17,7 @@ jobs: node: - 18 - 20 + - 22 steps: - name: Install Alpine build tools diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index 1d002e4ed..ddc9af976 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -22,6 +22,10 @@ jobs: gcc: "gcc-10" gpp: "g++-10" os: ubuntu-22.04 + - node: 22 + gcc: "gcc-10" + gpp: "g++-10" + os: ubuntu-22.04 steps: diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index d3da8b5cd..eef459bf7 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -16,6 +16,7 @@ jobs: node: - 18 - 20 + - 22 steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 50528faec..c12e193e6 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -14,10 +14,9 @@ jobs: fail-fast: false matrix: node: - - 16 - 18 - - 19 - 20 + - 22 architecture: - x64 diff --git a/README.md b/README.md index 125dee83f..ec863cb07 100644 --- a/README.md +++ b/README.md @@ -18,10 +18,10 @@ Below is a quick guide for minimum and maximum supported versions of node-sass: NodeJS | Supported node-sass version | Node Module --------|-----------------------------|------------ Node 20 | 9.0+ | 115 -Node 19 | 8.0+ | 111 +Node 19 | 8.0+, <=9.0 | 111 Node 18 | 8.0+ | 108 Node 17 | 7.0+, <8.0 | 102 -Node 16 | 6.0+ | 93 +Node 16 | 6.0+, <=9.0 | 93 Node 15 | 5.0+, <7.0 | 88 Node 14 | 4.14+, <9.0 | 83 Node 13 | 4.13+, <5.0 | 79 diff --git a/appveyor.yml b/appveyor.yml index 4aeb15ad8..cb9ff6f1b 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -39,6 +39,9 @@ - nodejs_version: 20 GYP_MSVS_VERSION: 2019 APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019 + - nodejs_version: 22 + GYP_MSVS_VERSION: 2019 + APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019 install: diff --git a/lib/extensions.js b/lib/extensions.js index 24314b8bd..445552594 100644 --- a/lib/extensions.js +++ b/lib/extensions.js @@ -85,6 +85,7 @@ function getHumanNodeVersion(abi) { case 108: return 'Node.js 18.x'; case 111: return 'Node.js 19.x'; case 115: return 'Node.js 20.x'; + case 127: return 'Node.js 22.x'; default: return false; } } diff --git a/package.json b/package.json index 76770768a..cd921973a 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ "url": "http://andrew.github.com" }, "engines": { - "node": "^18 || ^20" + "node": "^18 || ^20 || >= 22" }, "main": "lib/index.js", "nodeSassConfig": {