Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit topic fails when MIN_INSYNC_REPLICAS_CONFIG is not present #35

Closed
tmgstevens opened this issue Jul 16, 2024 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@tmgstevens
Copy link

Describe the bug
When using non-Kafka implementations that don't have the concept of ISR, you cannot edit a topic

To Reproduce
Steps to reproduce the behavior:

  1. Deploy Redpanda (https://docs.redpanda.com/current/get-started/quick-start/?tab=tabs-1-single-broker)
  2. Connect to Redpanda kaskade admin -b localhost:9092
  3. Create topic
  4. Edit topic

Expected behavior
Not crash

Screenshots

╭──────────────────────────────────────── Traceback (most recent call last) ─────────────────────────────────────────╮
│ /opt/homebrew/Cellar/kaskade/2.2.0/libexec/lib/python3.12/site-packages/kaskade/admin.py:432 in action_edit        │
│                                                                                                                    │
│   429 │   │   edit_topic_screen = EditTopicScreen(                                                                 │
│   430 │   │   │   self.current_topic.name,                                                                         │
│   431 │   │   │   str(self.current_topic.partitions_count()),                                                      │
│ ❱ 432 │   │   │   topic_configs[MIN_INSYNC_REPLICAS_CONFIG],                                                       │
│   433 │   │   │   topic_configs[CLEANUP_POLICY_CONFIG],                                                            │
│   434 │   │   │   topic_configs[RETENTION_MS_CONFIG],                                                              │
│   435 │   │   )                                                                                                    │
│                                                                                                                    │
│ ╭────────────────────────── locals ───────────────────────────╮                                                    │
│ │          self = ListTopics()                                │                                                    │
│ │ topic_configs = {                                           │                                                    │
│ │                 │   'compression.type': 'producer',         │                                                    │
│ │                 │   'cleanup.policy': 'delete',             │                                                    │
│ │                 │   'segment.bytes': '134217728',           │                                                    │
│ │                 │   'retention.ms': '604800000',            │                                                    │
│ │                 │   'retention.bytes': '-1',                │                                                    │
│ │                 │   'message.timestamp.type': 'CreateTime', │                                                    │
│ │                 │   'max.message.bytes': '1048576',         │                                                    │
│ │                 │   'write.caching': 'true',                │                                                    │
│ │                 │   'flush.bytes': '262144',                │                                                    │
│ │                 │   'flush.ms': '100',                      │                                                    │
│ │                 │   ... +8                                  │                                                    │
│ │                 }                                           │                                                    │
│ ╰─────────────────────────────────────────────────────────────╯                                                    │
╰────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
KeyError: 'min.insync.replicas'

Desktop (please complete the following information):

  • OS: iOS
  • Version 12.5.1
  • Python Version 3.12

Additional context
Add any other context about the problem here.

@tmgstevens tmgstevens added the bug Something isn't working label Jul 16, 2024
@sauljabin
Copy link
Owner

hi @tmgstevens thanks!, fixing it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants