-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spatial: Remove 'Robin' boundary conditions? #382
Comments
we left them in, in the past, since JSim needed them. While they might not have yet implemented support for spatial. It does not hurt to leave them . But i'm fine with removing them too. |
At this point, I'm going to drop them in the name of simplicity, and not implying to future simulator authors that they're standard. (I'll need a corresponding change in libsbml as well.) |
Fixed with fe60dc2 and sbmlteam/libsbml#263 |
Whoops, copied responses to the wrong issue: From @jcschaff : VCell does have support for
VCell does not have plans to offer Robin/Mixed boundary conditions in the near future. |
From @bartjuw : We, JSim users, used this when dealing 1D flow through a capillary. It specifies the boundary condition for the left hand side (input).
|
bartjuw : If I recall correctly, JSim doesn't support import or export of SBML-spatial at this time, though, correct? |
From @bartjuw: |
(Copied over the comments and removing them from the other unrelated issue, for posterity.) |
@matthiaskoenig notes that the 'Robin' boundary condition is not very common, and wanted to make sure there were implementations of it before approving the spec as an editor. Does anyone implement support for Robin in the context of sbml-spatial? If not, I'll remove it.
The text was updated successfully, but these errors were encountered: