Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial validation rule 21350 too stringent #392

Closed
luciansmith opened this issue Oct 27, 2022 · 3 comments
Closed

Spatial validation rule 21350 too stringent #392

luciansmith opened this issue Oct 27, 2022 · 3 comments
Assignees

Comments

@luciansmith
Copy link
Member

Rule 21350 only applies when the mapped compartments are the same dimensions, not if they are different (cf sbmlteam/libsbml#275).

The new rule should be:

"The value of the attribute \token{spatial:unitSize} on a \CompartmentMapping must have a value between 0 and 1, inclusive, when the dimensions of the referenced compartments have the same dimensions."

@luciansmith
Copy link
Member Author

I'm inclined to make this change before submitting to JIB. @fbergmann , opinions?

@fbergmann
Copy link
Member

If we change it, since really it is a best guidance rule, we additionally should change it from a must to a should. This is also what came out in discussions with @jcschaff. I'm happy for it to change in time for the JIB thing. it does not change anything form the spec, other than this validation rule.

@luciansmith
Copy link
Member Author

Sounds good to me! Changed from 'must' to 'should', and downgraded it to a warning instead of an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants